linux-kernel - Re: [PATCH V10 00/28] Add new powerpc specific ELF core notes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1465384736.13854.5.camel@ellerman.id.au>
Date:	Wed, 08 Jun 2016 21:18:56 +1000
From:	Michael Ellerman <mpe@...erman.id.au>
To:	Anshuman Khandual <khandual@...ux.vnet.ibm.com>,
	Cyril Bur <cyrilbur@...il.com>
Cc:	Laurent Dufour <ldufour@...ux.vnet.ibm.com>,
	Michael Neuling <mikey@...ling.org>, james.hogan@...tec.com,
	avagin@...nvz.org, Paul.Clothier@...tec.com,
	Ulrich.Weigand@...ibm.com, peterz@...radead.org, palves@...hat.com,
	emachado@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	shuahkh@....samsung.com, dhowells@...hat.com,
	linuxppc-dev@...abs.org, kirjanov@...il.com, oleg@...hat.com,
	davej@...hat.com, tglx@...utronix.de, sukadev@...ux.vnet.ibm.com,
	davem@...emloft.net, sam.bobroff@....ibm.com
Subject: Re: [PATCH V10 00/28] Add new powerpc specific ELF core notes

On Mon, 2016-06-06 at 14:27 +0530, Anshuman Khandual wrote:
> On 06/03/2016 03:56 AM, Cyril Bur wrote:
> > 
> > At the moment is is rather confusing since pt_regs is the always the 'live'
> > state and theres a ckpt_regs that is the pt_regs for the checkpointed state.
> > FPU/VMX/VSX is done differently which is really only creating confusion so I'm changing
> > it to do the same at for pt_regs/ckpt_regs. Ultimately this is part of more work from me
> 
> But that changes the basic semantics on which this ptrace series is written.
> With this change, a significant part of the ptrace series has to be changed.

Yes, that's the whole point.

In fact half of the code should vanish, because the only difference between
copying the live or checkpointed state out to userspace should be which regs
struct you pass to the function.

> Its just an improvement on how we store running and check pointed values for
> FP/VSX/VMX registers inside the kernel. How does it improve ptrace interface
> from the user point of view ? If not, then why this change is necessary for
> the acceptance of this patch series ?

Because the clean-ups never happen once a series is merged, and I'm left to deal
with it.

cheers