linux-kernel - Re: [PATCH V2] Use MACRO UINT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160608020525.GA16012@MinfeideMacBook-Pro.local>
Date:	Wed, 8 Jun 2016 10:05:25 +0800
From:	Minfei Huang <mnghuan@...il.com>
To:	keith.busch@...el.com, axboe@...com, gpiccoli@...ux.vnet.ibm.com,
	sagi@...mberg.me
Cc:	linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] Use MACRO UINT_MAX instead of actual value

Ping. Any comment is appreciate.

Thanks
Minfei

On 05/17/16 at 03:58P, Minfei Huang wrote:
> It's more elegant to use MACRO UINT_MAX to represent the max value of
> type unsigned int. So replace the actual value by using this MACRO.
> 
> Signed-off-by: Minfei Huang <mnghuan@...il.com>
> ---
> v1:
> - fix typo
> ---
>  drivers/nvme/host/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 643f457..2c0bb13 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -597,7 +597,7 @@ static void nvme_config_discard(struct nvme_ns *ns)
>  
>  	ns->queue->limits.discard_alignment = logical_block_size;
>  	ns->queue->limits.discard_granularity = logical_block_size;
> -	blk_queue_max_discard_sectors(ns->queue, 0xffffffff);
> +	blk_queue_max_discard_sectors(ns->queue, UINT_MAX);
>  	queue_flag_set_unlocked(QUEUE_FLAG_DISCARD, ns->queue);
>  }
>  
> -- 
> 2.6.3
>