[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <57582B97.5040402@mentor.com>
Date: Wed, 8 Jun 2016 17:28:39 +0300
From: Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>
To: Wolfram Sang <wsa@...-dreams.de>
CC: Wim Van Sebroeck <wim@...ana.be>,
Guenter Roeck <linux@...ck-us.net>,
Robin Gong <b38343@...escale.com>,
<linux-watchdog@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 5/6] watchdog: pretimeout: add panic pretimeout
governor
Hi Wolfram,
On 08.06.2016 10:08, Wolfram Sang wrote:
>
>> +static void pretimeout_panic(struct watchdog_device *wdd)
>> +{
>> + panic("panic on watchdog pretimeout event\n");
>> +}
>
> And here we have the same redundant message again ("panic on") :(
I will remove it then.
> Did you look at my patches at all? To me, it looks like you didn't or
> you are intentionally trying to leave my changes out. I don't think they
> were all bad.
No, they are not, and I'll include some of the changes to v4, if you don't
mind.
> In the previous patch in watchdog_notify_pretimeout() you used
> the shortened message BTW.
--
With best wishes,
Vladimir
Powered by blists - more mailing lists