linux-kernel - Re: [PATCH v3 04/30] staging: unisys: visorbus: remove unused module parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20160608150024.GE10331@neilslaptop.think-freely.org>
Date:	Wed, 8 Jun 2016 11:00:24 -0400
From:	Neil Horman <nhorman@...hat.com>
To:	"Binder, David Anthony" <David.Binder@...sys.com>
Cc:	"Kershner, David A" <David.Kershner@...sys.com>,
	"corbet@....net" <corbet@....net>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"Arfvidson, Erik" <Erik.Arfvidson@...sys.com>,
	"Sell, Timothy C" <Timothy.Sell@...sys.com>,
	"hofrat@...dl.org" <hofrat@...dl.org>,
	"dzickus@...hat.com" <dzickus@...hat.com>,
	"jes.sorensen@...hat.com" <jes.sorensen@...hat.com>,
	"Curtin, Alexander Paul" <Alexander.Curtin@...sys.com>,
	"janani.rvchndrn@...il.com" <janani.rvchndrn@...il.com>,
	"sudipm.mukherjee@...il.com" <sudipm.mukherjee@...il.com>,
	"prarit@...hat.com" <prarit@...hat.com>,
	"dan.j.williams@...el.com" <dan.j.williams@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"driverdev-devel@...uxdriverproject.org" 
	<driverdev-devel@...uxdriverproject.org>,
	*S-Par-Maintainer <SParMaintainer@...sys.com>
Subject: Re: [PATCH v3 04/30] staging: unisys: visorbus: remove unused module
 parameters

On Wed, Jun 08, 2016 at 02:42:08PM +0000, Binder, David Anthony wrote:
> > -----Original Message-----
> > From: Neil Horman [mailto:nhorman@...hat.com]
> > Sent: Wednesday, June 08, 2016 9:08 AM
> > To: Binder, David Anthony <David.Binder@...sys.com>
> > Cc: Kershner, David A <David.Kershner@...sys.com>; corbet@....net;
> > tglx@...utronix.de; mingo@...hat.com; hpa@...or.com;
> > gregkh@...uxfoundation.org; Arfvidson, Erik <Erik.Arfvidson@...sys.com>;
> > Sell, Timothy C <Timothy.Sell@...sys.com>; hofrat@...dl.org;
> > dzickus@...hat.com; jes.sorensen@...hat.com; Curtin, Alexander Paul
> > <Alexander.Curtin@...sys.com>; janani.rvchndrn@...il.com;
> > sudipm.mukherjee@...il.com; prarit@...hat.com;
> > dan.j.williams@...el.com; linux-kernel@...r.kernel.org; linux-
> > doc@...r.kernel.org; driverdev-devel@...uxdriverproject.org; *S-Par-
> > Maintainer <SParMaintainer@...sys.com>
> > Subject: Re: [PATCH v3 04/30] staging: unisys: visorbus: remove unused
> > module parameters
> > 
> > On Wed, Jun 08, 2016 at 02:13:47AM +0000, Binder, David Anthony wrote:
> > > > -----Original Message-----
> > > > From: Neil Horman [mailto:nhorman@...hat.com]
> > > > Sent: Tuesday, June 07, 2016 9:23 AM
> > > > To: Kershner, David A <David.Kershner@...sys.com>
> > > > Cc: corbet@....net; tglx@...utronix.de; mingo@...hat.com;
> > > > hpa@...or.com; gregkh@...uxfoundation.org; Arfvidson, Erik
> > > > <Erik.Arfvidson@...sys.com>; Sell, Timothy C
> > <Timothy.Sell@...sys.com>;
> > > > hofrat@...dl.org; dzickus@...hat.com; jes.sorensen@...hat.com;
> > Curtin,
> > > > Alexander Paul <Alexander.Curtin@...sys.com>;
> > > > janani.rvchndrn@...il.com; sudipm.mukherjee@...il.com;
> > > > prarit@...hat.com; Binder, David Anthony <David.Binder@...sys.com>;
> > > > dan.j.williams@...el.com; linux-kernel@...r.kernel.org; linux-
> > > > doc@...r.kernel.org; driverdev-devel@...uxdriverproject.org; *S-Par-
> > > > Maintainer <SParMaintainer@...sys.com>
> > > > Subject: Re: [PATCH v3 04/30] staging: unisys: visorbus: remove unused
> > > > module parameters
> > > >
> > > > On Sat, Jun 04, 2016 at 01:27:04PM -0400, David Kershner wrote:
> > > > > From: David Binder <david.binder@...sys.com>
> > > > >
> > > > > Removes unused module parameters from visorbus_main.c, in
> > response to
> > > > > findings by SonarQube.
> > > > >
> > > > > Signed-off-by: David Binder <david.binder@...sys.com>
> > > > > Signed-off-by: David Kershner <david.kershner@...sys.com>
> > > > > Reviewed-by: Tim Sell <Timothy.Sell@...sys.com>
> > > > > ---
> > > > >  drivers/staging/unisys/visorbus/visorbus_main.c | 9 +--------
> > > > >  1 file changed, 1 insertion(+), 8 deletions(-)
> > > > >
> > > > > diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
> > > > b/drivers/staging/unisys/visorbus/visorbus_main.c
> > > > > index 2ed9628..71bff07 100644
> > > > > --- a/drivers/staging/unisys/visorbus/visorbus_main.c
> > > > > +++ b/drivers/staging/unisys/visorbus/visorbus_main.c
> > > > > @@ -27,10 +27,9 @@
> > > > >  #define MYDRVNAME "visorbus"
> > > > >
> > > > >  /* module parameters */
> > > > > -static int visorbus_debug;
> > > > >  static int visorbus_forcematch;
> > > > >  static int visorbus_forcenomatch;
> > > > > -static int visorbus_debugref;
> > > > > +
> > > > >  #define SERIALLOOPBACKCHANADDR (100 * 1024 * 1024)
> > > > >
> > > > >  /* Display string that is guaranteed to be no longer the 99 characters*/
> > > > > @@ -1332,9 +1331,6 @@ visorbus_exit(void)
> > > > >  	remove_bus_type();
> > > > >  }
> > > > >
> > > > > -module_param_named(debug, visorbus_debug, int, S_IRUGO);
> > > > > -MODULE_PARM_DESC(visorbus_debug, "1 to debug");
> > > > > -
> > > > >  module_param_named(forcematch, visorbus_forcematch, int,
> > S_IRUGO);
> > > > >  MODULE_PARM_DESC(visorbus_forcematch,
> > > > >  		 "1 to force a successful dev <--> drv match");
> > > > > @@ -1342,6 +1338,3 @@ MODULE_PARM_DESC(visorbus_forcematch,
> > > > >  module_param_named(forcenomatch, visorbus_forcenomatch, int,
> > > > S_IRUGO);
> > > > >  MODULE_PARM_DESC(visorbus_forcenomatch,
> > > > >  		 "1 to force an UNsuccessful dev <--> drv match");
> > > > > -
> > > > > -module_param_named(debugref, visorbus_debugref, int, S_IRUGO);
> > > > > -MODULE_PARM_DESC(visorbus_debugref, "1 to debug reference
> > > > counting");
> > > >
> > > > visorbus_forcematch and visorbus_forcenomatch appear to be
> > referenced in
> > > > visorbus_match (at least in the HEAD of linus' tree).  If you're going to
> > > > remove
> > > > the module parameters, why not also remove those references and the
> > > > force[no]match variables themselves?
> > > >
> > > > Neil
> > >
> > > We presently use visorbus_forcematch and visorbus_forcenomatch for
> > > debugging purposes, and therefore decided to keep the variables in
> > > the driver.
> > >
> > Ok, thats fine, but this seems like a half measure then.  This patch removes
> > the
> > module option for those features, which means that for you to use them,
> > you have
> > to rebuild the module.  If you have intentions to use it, why not just leave
> > the
> > module option in place?  If you don't, remove it all the way.
> > 
> > Neil
> > 
> > > David Binder
> 
> Unless I'm missing something, the patch removes the module parameters for 
> visorbus_debug and visorbus_debugref, but it leaves the parameters for 
> visorbus_forcematch and visorbus_forcenomatch. 
> 
> David Binder

Sorry, you're absolutely right, I wasn't looking closely enough, you're fine
here.  Apologies.
Neil