linux-kernel - Re: [PATCH] mfd: max77620: Constify resources tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160608153957.GZ14888@dell>
Date:	Wed, 8 Jun 2016 16:39:57 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Laxman Dewangan <ldewangan@...dia.com>,
	Mallikarjun Kasoju <mkasoju@...dia.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: max77620: Constify resources tables

On Sun, 05 Jun 2016, Axel Lin wrote:

> These tables are never modified, so declare them as const.
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>  drivers/mfd/max77620.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/max77620.c b/drivers/mfd/max77620.c
> index 199d261..e831422 100644
> --- a/drivers/mfd/max77620.c
> +++ b/drivers/mfd/max77620.c
> @@ -37,19 +37,19 @@
>  #include <linux/regmap.h>
>  #include <linux/slab.h>
>  
> -static struct resource gpio_resources[] = {
> +static const struct resource gpio_resources[] = {
>  	DEFINE_RES_IRQ(MAX77620_IRQ_TOP_GPIO),
>  };
>  
> -static struct resource power_resources[] = {
> +static const struct resource power_resources[] = {
>  	DEFINE_RES_IRQ(MAX77620_IRQ_LBT_MBATLOW),
>  };
>  
> -static struct resource rtc_resources[] = {
> +static const struct resource rtc_resources[] = {
>  	DEFINE_RES_IRQ(MAX77620_IRQ_TOP_RTC),
>  };
>  
> -static struct resource thermal_resources[] = {
> +static const struct resource thermal_resources[] = {
>  	DEFINE_RES_IRQ(MAX77620_IRQ_LBT_TJALRM1),
>  	DEFINE_RES_IRQ(MAX77620_IRQ_LBT_TJALRM2),
>  };

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog