linux-kernel - Re: [tip:x86/urgent] x86/quirks: Add early quirk to reset Apple AirPort card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160609064803.GA10996@gmail.com>
Date:	Thu, 9 Jun 2016 08:48:03 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Lukas Wunner <lukas@...ner.de>
Cc:	Yinghai Lu <yinghai@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>, cmilsted@...hat.com,
	Rafa?? Mi??ecki <zajec5@...il.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Matt Fleming <matt@...eblueprint.co.uk>,
	Peter Zijlstra <peterz@...radead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Matthew Garrett <mjg59@...f.ucam.org>, m@...s.ch,
	"linux-tip-commits@...r.kernel.org" 
	<linux-tip-commits@...r.kernel.org>
Subject: Re: [tip:x86/urgent] x86/quirks: Add early quirk to reset Apple
 AirPort card


* Lukas Wunner <lukas@...ner.de> wrote:

> > How do you know that sec is valid ?
> > 
> > How about on the system that have one bridge that still have sec num register 0?
> > 
> > it will be get into dead loop.
> 
> Good point. I've just checked pci_scan_bridge() and it does verify that and 
> avoids recursing to a child bus if it's number is zero. It also ensures that sec
> > num before recursing.
> 
> I can provide a follow-up patch to fix that, will wait a bit though to see if 
> there are further comments.

Please send a delta fix on top of x86/urgent. (I'll probably squash the two fixes 
together.)

Thanks,

	Ingo