linux-kernel - Re: [PATCH] s390/oprofile: Remove deprecated create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160609090056.GC3250@osiris>
Date:	Thu, 9 Jun 2016 11:00:56 +0200
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Bhaktipriya Shridhar <bhaktipriya96@...il.com>
Cc:	Robert Richter <rric@...nel.org>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Tejun Heo <tj@...nel.org>, oprofile-list@...ts.sf.net,
	linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
	Hendrik Brueckner <brueckner@...ux.vnet.ibm.com>,
	Andreas Krebbel <krebbel@...ux.vnet.ibm.com>,
	Andreas Arnez <arnez@...ux.vnet.ibm.com>,
	William Cohen <wcohen@...hat.com>
Subject: Re: [PATCH] s390/oprofile: Remove deprecated create_workqueue

On Wed, Jun 08, 2016 at 03:29:12AM +0530, Bhaktipriya Shridhar wrote:
> A dedicated workqueue has been used since the workqueue hws_wq with
> workitem &cb->worker, is involved in hardware based sampling
> on System z processors.
> 
> Since, these are long-running work items and aren't involved in memory
> reclaim in any way, system_long_wq has been used.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@...il.com>
> ---
>  arch/s390/oprofile/hwsampler.c | 21 +++------------------
>  1 file changed, 3 insertions(+), 18 deletions(-)

Besides that your patch doesn't compile... ;)

Removing the flush_workqueue is probably wrong, since the oprofile module
can now be unloaded while there could still be a reference to a worker
structure owned by the oprofile module.

However I'm wondering if we shouldn't simply remove at least the s390
specific hwswampler code from the oprofile module. This would still leave
the common code timer based sampling mode for oprofile working on s390.

It looks like the oprofile user space utility nowadays (since 2012) uses
the kernel perf interface instead of the oprofile interface anyway, if
present. So the oprofile module itself doesn't seem to have too many users
left.

Any opinions?

> 
> -		if (hws_wq)
> -			flush_workqueue(hws_wq);
> -
>  		mutex_lock(&hws_sem);
> 
>  		if (hws_state == HWS_STOPPED) {
> @@ -1059,10 +1048,6 @@ int hwsampler_shutdown(void)
>  			hws_alert = 0;
>  			deallocate_sdbt();
>  		}
> -		if (hws_wq) {
> -			destroy_workqueue(hws_wq);
> -			hws_wq = NULL;
> -		}
> 
>  		unregister_external_irq(EXT_IRQ_MEASURE_ALERT, hws_ext_handler);
>  		hws_state = HWS_INIT;
> --
> 2.1.4
>