linux-kernel - [PATCH] lib: lcm.c: make __attribute_const_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1465471892-18604-1-git-send-email-ben.dooks@codethink.co.uk>
Date:	Thu,  9 Jun 2016 12:31:32 +0100
From:	Ben Dooks <ben.dooks@...ethink.co.uk>
To:	linux-kernel@...ts.codethink.co.uk
Cc:	Ben Dooks <ben.dooks@...ethink.co.uk>, linux-kernel@...r.kernel.org
Subject: [PATCH] lib: lcm.c: make __attribute_const__ consistent

The lcm and lcm_not_zero() are producing sparse warnings due to
the use of __attribute_const__ in the header but not in the lcm.c
file. Add the __attribute_const__ to lcm.c and make the header
consistent with using the attribute before the function to fix
the following sparse warnings:

lib/lcm.c:7:15: error: symbol 'lcm' redeclared with different type (originally declared at include/linux/lcm.h:6) - different modifiers
lib/lcm.c:16:15: error: symbol 'lcm_not_zero' redeclared with different type (originally declared at include/linux/lcm.h:7) - different modifiers

Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
---
Cc: linux-kernel@...r.kernel.org

Note, this makes scripts/get_maintainer.pl go:
Bad divisor in main::vcs_assign: 0
Bad divisor in main::vcs_assign: 0
---
 include/linux/lcm.h | 4 ++--
 lib/lcm.c           | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/linux/lcm.h b/include/linux/lcm.h
index 1ce79a7..a1bb0bb 100644
--- a/include/linux/lcm.h
+++ b/include/linux/lcm.h
@@ -3,7 +3,7 @@
 
 #include <linux/compiler.h>
 
-unsigned long lcm(unsigned long a, unsigned long b) __attribute_const__;
-unsigned long lcm_not_zero(unsigned long a, unsigned long b) __attribute_const__;
+unsigned long __attribute_const__ lcm(unsigned long a, unsigned long b);
+unsigned long __attribute_const__ lcm_not_zero(unsigned long a, unsigned long b);
 
 #endif /* _LCM_H */
diff --git a/lib/lcm.c b/lib/lcm.c
index 03d7fcb..ced8532 100644
--- a/lib/lcm.c
+++ b/lib/lcm.c
@@ -4,7 +4,7 @@
 #include <linux/lcm.h>
 
 /* Lowest common multiple */
-unsigned long lcm(unsigned long a, unsigned long b)
+unsigned long __attribute_const__ lcm(unsigned long a, unsigned long b)
 {
 	if (a && b)
 		return (a / gcd(a, b)) * b;
@@ -13,7 +13,7 @@ unsigned long lcm(unsigned long a, unsigned long b)
 }
 EXPORT_SYMBOL_GPL(lcm);
 
-unsigned long lcm_not_zero(unsigned long a, unsigned long b)
+unsigned long __attribute_const__ lcm_not_zero(unsigned long a, unsigned long b)
 {
 	unsigned long l = lcm(a, b);
 
-- 
2.8.1