linux-kernel - Re: [PATCH 2/2] ARM: dts: TS-4800: add CAN support

Open Source and information security mailing list archives

Message-ID: <20160609133057.GB19473@tiger>
Date:	Thu, 9 Jun 2016 21:30:57 +0800
From:	Shawn Guo <shawnguo@...nel.org>
To:	Damien Riegel <damien.riegel@...oirfairelinux.com>
Cc:	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Mark Rutland <mark.rutland@....com>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Russell King <linux@...linux.org.uk>,
	Rob Herring <robh+dt@...nel.org>, kernel@...oirfairelinux.com,
	Sascha Hauer <kernel@...gutronix.de>,
	Kumar Gala <galak@...eaurora.org>
Subject: Re: [PATCH 2/2] ARM: dts: TS-4800: add CAN support

On Tue, May 17, 2016 at 04:16:30PM -0400, Damien Riegel wrote:
> This enables support for the CAN controller located in the FPGA.
> 
> Signed-off-by: Damien Riegel <damien.riegel@...oirfairelinux.com>
> ---
>  arch/arm/boot/dts/imx51-ts4800.dts | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx51-ts4800.dts b/arch/arm/boot/dts/imx51-ts4800.dts
> index 2c89988..41be82e 100644
> --- a/arch/arm/boot/dts/imx51-ts4800.dts
> +++ b/arch/arm/boot/dts/imx51-ts4800.dts
> @@ -149,6 +149,16 @@
>  		#size-cells = <1>;
>  		ranges = <0 0 0 0x1d000>;
>  
> +		can@0,1a000 {
> +			compatible = "technologic,sja1000";
> +			reg = <0x1a000 0x00000100>;
> +			interrupt-parent = <&fpga_irqc>;
> +			interrupts = <1>;
> +			reg-io-width = <2>;
> +			nxp,tx-output-config = <0x06>;
> +			nxp,external-clock-frequency = <24000000>;
> +		};
> +

For nodes under bus node with unit-address (or 'reg' property), it makes
more sense to sort the nodes in order of unit-address.

Shawn

>  		fpga_irqc: fpga_irqc@0,15000 {
>  			compatible = "technologic,ts4800-irqc";
>  			reg = <0x15000 0x1000>;
> -- 
> 2.5.0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives