linux-kernel - Re: [PATCH V3] watchdog: max77620: Add support for watchdog timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57597032.8040008@roeck-us.net>
Date:	Thu, 9 Jun 2016 06:33:38 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Laxman Dewangan <ldewangan@...dia.com>, wim@...ana.be
Cc:	linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org
Subject: Re: [PATCH V3] watchdog: max77620: Add support for watchdog timer

On 06/08/2016 06:39 AM, Laxman Dewangan wrote:
> Maxim PMIC MAX77620 is Power management IC which have multiple
> sub blocks like regulators (DCDC/LDOs), GPIO, RTC, Clock, Watchdog
> timer etc.
>
> Add the driver for watchdog timer under watchdog framework.
> The driver implements the watchdog callbacks to start, stop,
> ping and set timeout for watchodg framework.
>
> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>

Mostly good.

[ ... ]

> +	/* Check if WDT running and ig yes then set flags properly */

s/ig/if/

Please fix this up and resend, with

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

Can you by any chance send me a copy of the datasheet ? I wanted to look up the
chip default for the watchdog timeout and realized that the chip does not
officially exist.

Thanks,
Guenter