linux-kernel - Re: [PATCH v2 10/10] x86, asm: Use CC_SET()/CC_OUT() and static_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160609154926.GB15900@pd.tnic>
Date:	Thu, 9 Jun 2016 17:49:26 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	"H. Peter Anvin" <hpa@...ux.intel.com>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andy Lutomirski <luto@...capital.net>
Subject: Re: [PATCH v2 10/10] x86, asm: Use CC_SET()/CC_OUT() and
 static_cpu_has() in archrandom.h

On Wed, Jun 08, 2016 at 12:38:46PM -0700, H. Peter Anvin wrote:
> Use CC_SET()/CC_OUT() and static_cpu_has().  This produces code good
> enough to eliminate ad hoc use of alternatives in <asm/archrandom.h>,
> greatly simplifying the code.
> 
> While we are at it, make x86_init_rdrand() compile out completely if
> we don't need it.
> 
> Signed-off-by: H. Peter Anvin <hpa@...ux.intel.com>
> 
> v2: fix a conflict between <linux/random.h> and <asm/archrandom.h>
>     discovered by Ingo Molnar.  There are a few places in x86-specific
>     code where we need all of <arch/archrandom.h> even when
>     CONFIG_ARCH_RANDOM is disabled, so <linux/random.h> does not
>     suffice.
> ---
>  arch/x86/include/asm/archrandom.h | 128 ++++++++++++++++++--------------------
>  arch/x86/kernel/cpu/rdrand.c      |   4 +-
>  2 files changed, 62 insertions(+), 70 deletions(-)

Reviewed-by: Borislav Petkov <bp@...e.de>

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.