lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 9 Jun 2016 04:22:48 +0200 From: Andrew Lunn <andrew@...n.ch> To: Vivien Didelot <vivien.didelot@...oirfairelinux.com> Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kernel@...oirfairelinux.com, "David S. Miller" <davem@...emloft.net>, Florian Fainelli <f.fainelli@...il.com> Subject: Re: [PATCH net-next 1/8] net: dsa: mv88e6xxx: fix style issues On Wed, Jun 08, 2016 at 08:44:49PM -0400, Vivien Didelot wrote: > This patch fixes 5 style problems reported by checkpatch: > > WARNING: suspect code indent for conditional statements (8, 24) > #492: FILE: drivers/net/dsa/mv88e6xxx.c:492: > + if (phydev->link) > + reg |= PORT_PCS_CTRL_LINK_UP; > > CHECK: Logical continuations should be on the previous line > #1318: FILE: drivers/net/dsa/mv88e6xxx.c:1318: > + oldstate == PORT_CONTROL_STATE_FORWARDING) > + && (state == PORT_CONTROL_STATE_DISABLED || > > CHECK: multiple assignments should be avoided > #1662: FILE: drivers/net/dsa/mv88e6xxx.c:1662: > + vlan->vid_begin = vlan->vid_end = next.vid; > > WARNING: line over 80 characters > #2097: FILE: drivers/net/dsa/mv88e6xxx.c:2097: > + const struct switchdev_obj_port_vlan *vlan, > > WARNING: suspect code indent for conditional statements (16, 32) > #2734: FILE: drivers/net/dsa/mv88e6xxx.c:2734: > + if (mv88e6xxx_6352_family(ps) || mv88e6xxx_6351_family(ps) || > [...] > + reg |= PORT_CONTROL_EGRESS_ADD_TAG; > > total: 0 errors, 3 warnings, 2 checks, 3805 lines checked > > Signed-off-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com> Reviewed-by: Andrew Lunn <andrew@...n.ch> Andrew
Powered by blists - more mailing lists