linux-kernel - Re: linux-next: build warnings after merge of the kbuild tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 9 Jun 2016 10:58:27 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Emese Revfy <re.emese@...il.com>
Cc:	Michal Marek <mmarek@...e.cz>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Linux-Next <linux-next@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build warnings after merge of the kbuild tree

On Thu, Jun 9, 2016 at 10:37 AM, Emese Revfy <re.emese@...il.com> wrote:
> On Thu, 9 Jun 2016 12:57:16 +0200
> Michal Marek <mmarek@...e.cz> wrote:
>
>> Dne 9.6.2016 v 06:05 Stephen Rothwell napsal(a):
>> > On Wed, 8 Jun 2016 19:56:38 -0700 Kees Cook <keescook@...omium.org> wrote:
>> >> Ah, yes, that should default to off. We'll get a fix landed ASAP.
>> >
>> > Note that this was an allmodconfig build.  The default is 'n', but
>> > allmodconfig will turn it on (as will allyesconfig).
>>
>> I guess we should make GCC_PLUGINS depend on !COMPILE_TEST. Actually I
>> thought this was already the case, but it is not.
>
> Is it really necessary to disable all gcc plugins or would it be enough
> to disable only the cyc_complexity plugin?

I think disabling (depend on !COMPILE_TEST) plugins that have
non-actionable output make sense. For example, in the future, things
like constify or initify may produce warnings that are "real" in the
sense that they have detected situations that should be fixed in the
code. In a perfect world, we would include those fixes ahead of the
new plugin to keep Stephen from going crazy. :)

-Kees

-- 
Kees Cook
Chrome OS & Brillo Security