linux-kernel - Re: [PATCH 4/6] mtd: nand: Add OMAP_GPMC as a dependency to MTD_NAND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160609204750.23e587dc@bbrezillon>
Date:	Thu, 9 Jun 2016 20:47:50 +0200
From:	Boris Brezillon <boris.brezillon@...e-electrons.com>
To:	Franklin S Cooper Jr <fcooper@...com>
Cc:	tony@...mide.com, computersforpeace@...il.com,
	linux-arm-kernel@...ts.infradead, linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org, linux-mtd@...ts.infradead.org
Subject: Re: [PATCH 4/6] mtd: nand: Add OMAP_GPMC as a dependency to
 MTD_NAND_OMAP2

On Thu,  9 Jun 2016 12:02:55 -0500
Franklin S Cooper Jr <fcooper@...com> wrote:

> OMAP 2 NAND depends on the GPMC driver. Therefore, insure that the OMAP
> GPMC config is selected before enabling the OMAP 2 NAND driver.
> 
> Signed-off-by: Franklin S Cooper Jr <fcooper@...com>
> ---
>  drivers/mtd/nand/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index f05e0e9..e24404f 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -89,7 +89,7 @@ config MTD_NAND_AMS_DELTA
>  
>  config MTD_NAND_OMAP2
>  	tristate "NAND Flash device on OMAP2, OMAP3 and OMAP4"
> -	depends on ARCH_OMAP2PLUS
> +	depends on ARCH_OMAP2PLUS && OMAP_GPMC

If you add

	depends on ARCH_OMAP2PLUS

in the OMAP_GPMC driver, you can just drop the ARCH_OMAP2PLUS
dependency here.

>  	help
>            Support for NAND flash on Texas Instruments OMAP2, OMAP3 and OMAP4
>  	  platforms.



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com