linux-kernel - Re: [PATCH V3 1/2] i2c: qup: Fix broken dma when CONFIG_DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 9 Jun 2016 22:46:55 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Sricharan <sricharan@...eaurora.org>
Cc:	linux-arm-msm@...r.kernel.org, ntelkar@...eaurora.org,
	agross@...eaurora.org, linux-kernel@...r.kernel.org,
	nkaje@...eaurora.org, absahu@...eaurora.org,
	linux-i2c@...r.kernel.org, galak@...eaurora.org,
	andy.gross@...aro.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH V3 1/2] i2c: qup: Fix broken dma when CONFIG_DEBUG_SG is
 enabled


>  The coherency is not dropped here. dma_map/unmap used
>  makes the buffer coherent before passing it to
>  dmaengine. Previously it was not required.
>  I can add this in description if its not clear.

Please do.

> 
>  >> @@ -1268,6 +1260,8 @@ static int qup_i2c_xfer_v2(struct i2c_adapter *adap,
> >>  		}
> >>  	}
> >>
> >> +	idx = 0;
> >> +
> >
> >This looks like an unrelated change.
>     Ha, wrong. This should have been in a separate patch.

Exactly this is what I meant with "unrelated" :)


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)