linux-kernel - Re: [ibm-acpi-devel] [PATCH v2] thinkpad_acpi: Add support for HKEY version 0x200

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160609211840.GP28348@f23x64.localdomain>
Date:	Thu, 9 Jun 2016 14:18:40 -0700
From:	Darren Hart <dvhart@...radead.org>
To:	Henrique de Moraes Holschuh <hmh@....eng.br>
Cc:	Marco Trevisan (Treviño) <mail@...n0.net>,
	Lyude <cpaul@...hat.com>,
	Dennis Wassenberg <dennis.wassenberg@...unet.com>,
	Henrique de Moraes Holschuh <ibm-acpi@....eng.br>,
	open list <linux-kernel@...r.kernel.org>,
	"open list:THINKPAD ACPI EXTRAS DRIVER" 
	<platform-driver-x86@...r.kernel.org>,
	"open list:THINKPAD ACPI EXTRAS DRIVER" 
	<ibm-acpi-devel@...ts.sourceforge.net>
Subject: Re: [ibm-acpi-devel] [PATCH v2] thinkpad_acpi: Add support for HKEY
 version 0x200

On Thu, Jun 09, 2016 at 06:04:52PM -0300, Henrique de Moraes Holschuh wrote:
> On Thu, 09 Jun 2016, Darren Hart wrote:
> > On Thu, Jun 09, 2016 at 01:05:12AM -0400, Marco Trevisan (Treviño) wrote:
> > > 2016-06-08 10:54 GMT-04:00 Lyude <cpaul@...hat.com>:
> > > > From: Dennis Wassenberg <dennis.wassenberg@...unet.com>
> > > >
> > > > Lenovo Thinkpad devices T460, T460s, T460p, T560, X260 use
> > > > HKEY version 0x200 without adaptive keyboard.
> > > >
> > > > HKEY version 0x200 has method MHKA with one parameter value.
> > > > Passing parameter value 1 will get hotkey_all_mask (the same like
> > > > HKEY version 0x100 without parameter). Passing parameter value 2 to
> > > > MHKA method will retrieve hotkey_all_adaptive_mask. If 0 is returned in
> > > > that case there is no adaptive keyboard available.
> > > >
> > > > Signed-off-by: Dennis Wassenberg <dennis.wassenberg@...unet.com>
> > > > Signed-off-by: Lyude <cpaul@...hat.com>
> > > > Tested-by: Lyude <cpaul@...hat.com>
> > > > Tested-by: Marco Trevisan <marco@...ntu.com>
> > > > Acked-by: Henrique de Moraes Holschuh <hmh@....eng.br>
> > > 
> > > Can you also Cc: stable@...r.kernel.org so that it can be imported
> > > there once merged?
> > 
> > It doesn't meet stable kernel rules unfortunately, with 143 lines diff.
> > 
> > Henrique, do you want to weigh in on whether this goes back to stable?
> 
> It should be in a bunch of -rc kernel releases before we even consider
> it.
> 
> > One thing I could do is include this in my 4.7-rc fixes branch instead of
> > waiting for 4.8.
> 
> If Linus will take it, I don't see a problem with that.

I'll do that.

-- 
Darren Hart
Intel Open Source Technology Center