linux-kernel - Re: powerpc/pseries: start rtasd before PCI probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160610084132.380bfba6@bahia.huguette.org>
Date:	Fri, 10 Jun 2016 08:41:32 +0200
From:	Greg Kurz <gkurz@...ux.vnet.ibm.com>
To:	Michael Ellerman <mpe@...erman.id.au>
Cc:	Michael Roth <mdroth@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org, qemu-ppc@...gnu.org,
	Paul Mackerras <paulus@...ba.org>,
	linuxppc-dev@...ts.ozlabs.org,
	David Gibson <david@...son.dropbear.id.au>
Subject: Re: powerpc/pseries: start rtasd before PCI probing

On Fri, 10 Jun 2016 15:18:32 +1000 (AEST)
Michael Ellerman <mpe@...erman.id.au> wrote:

> On Mon, 2016-23-05 at 08:28:28 UTC, Greg Kurz wrote:
> > A strange behaviour is observed when comparing PCI hotplug in QEMU, between
> > x86 and pseries. If you consider the following steps:
> > - start a VM
> > - add a PCI device via the QEMU monitor before the rtasd has started (for
> >   example starting the VM in paused state, or hotplug during FW or boot
> >   loader)
> > - resume the VM execution
> > 
> > The x86 kernel detects the PCI device, but the pseries one does not.
> > 
> > This happens because the rtasd kernel worker is currently started under
> > device_initcall, while PCI probing happens earlier under subsys_initcall.
> > 
> > As a consequence, if we have a pending RTAS event at boot time, a message
> > is printed and the event is dropped.
> > 
> > This patch moves all the initialization of rtasd to arch_initcall, which is
> > run before subsys_call: this way, logging_enabled is true when the RTAS
> > event pops up and it is not lost anymore.
> > 
> > The proc fs bits stay at device_initcall because they cannot be run before
> > fs_initcall.
> > 
> > Signed-off-by: Greg Kurz <gkurz@...ux.vnet.ibm.com>
> > Tested-by: Thomas Huth <thuth@...hat.com>  
> 
> Has this been tested on PowerVM ?
> 
> cheers
> 

No but I shall do it.

Thanks for pointing this out.

--
Greg