linux-kernel - Re: [PATCH trivial] include/linux/memcontrol.h: Clean up code only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 10 Jun 2016 08:40:30 +0800
From:	Chen Gang <chengang@...ndsoft.com.cn>
To:	Michal Hocko <mhocko@...nel.org>
CC:	akpm@...ux-foundation.org, trivial@...nel.org,
	vdavydov@...tuozzo.com, hannes@...xchg.org, davem@...emloft.net,
	tj@...nel.org, riel@...hat.com, linux-kernel@...r.kernel.org,
	Chen Gang <gang.chen.5i5j@...il.com>
Subject: Re: [PATCH trivial] include/linux/memcontrol.h: Clean up code only


On 6/9/16 23:46, Michal Hocko wrote:
> On Thu 09-06-16 23:23:52, chengang@...ndsoft.com.cn wrote:
>> From: Chen Gang <chengang@...ndsoft.com.cn>
>>
>> Merge several statements to one return statement, since the new return
>> statement is still simple enough.
>>
>> Try to let the second line function parameters almost align with the
>> first line parameter (try to be within 80 columns, and in one line).
>>
>> The comments can fully use 80 columns which can save one line.
>>
>> Use parameter name newpage instead of new (which will be key word color
>> in vim) for dummy mem_cgroup_migrate(), and real mem_cgroup_migrate()
>> already uses newpage.
> 
> What is the point of these changes? It removes few lines but does that
> actually make the code easier to read? To be honest I am not a big fan
> of such a stylist changes unless they are in a series of other changes
> which actually tweak the functionality. This just brings more churn
> to the git history.
> 

For me, if one line is simple enough, we need not use several lines to
express the same thing, especially a line within 80 columns can express
the whole function work in headers.

The public header files do not like body files, they are simple enough,
but their contents are often read through by another readers. So we need
more careful for coding styles, but less careful for git history.

> That's being said, I appreciate an interest in making the code cleaner
> but try to think whether these changes are actually helpful and who is
> going to benefit from them.
> 

For me, another readers can get benefit more or less from it: if read a
simple line can know the whole thing (function work), why need we read
multiple lines?

Thanks.
-- 
Chen Gang (陈刚)

Managing Natural Environments is the Duty of Human Beings.