linux-kernel - Re: [PATCH trivial] include/linux/memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <575A836A.5000606@emindsoft.com.cn>
Date:	Fri, 10 Jun 2016 17:07:54 +0800
From:	Chen Gang <chengang@...ndsoft.com.cn>
To:	kbuild test robot <lkp@...el.com>
CC:	kbuild-all@...org, akpm@...ux-foundation.org, trivial@...nel.org,
	mhocko@...e.cz, dan.j.williams@...el.com, iamjoonsoo.kim@....com,
	vbabka@...e.cz, baiyaowei@...s.chinamobile.com,
	vkuznets@...hat.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, Chen Gang <gang.chen.5i5j@...il.com>
Subject: Re: [PATCH trivial] include/linux/memory_hotplug.h: Clean up code

On 6/10/16 14:11, kbuild test robot wrote:
> Hi,
> 
> [auto build test ERROR on next-20160609]
> [also build test ERROR on v4.7-rc2]
> [cannot apply to v4.7-rc2 v4.7-rc1 v4.6-rc7]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 

Oh, my patch is for linux-next 20160609 tree, can not apply to v4.7-rc2
directly.

[...]

> 
>    In file included from include/linux/mmzone.h:741:0,
>                     from include/linux/gfp.h:5,
>                     from include/linux/kmod.h:22,
>                     from include/linux/module.h:13,
>                     from include/linux/moduleloader.h:5,
>                     from arch/blackfin/kernel/module.c:9:
>    include/linux/memory_hotplug.h: In function 'mhp_notimplemented':
>>> include/linux/memory_hotplug.h:225:2: error: 'mod' undeclared (first use in this function)
>    include/linux/memory_hotplug.h:225:2: note: each undeclared identifier is reported only once for each function it appears in
> 
> vim +/mod +225 include/linux/memory_hotplug.h
> 
>    219	static inline void zone_span_writelock(struct zone *zone) {}
>    220	static inline void zone_span_writeunlock(struct zone *zone) {}
>    221	static inline void zone_seqlock_init(struct zone *zone) {}
>    222	
>    223	static inline int mhp_notimplemented(const char *func)
>    224	{
>  > 225		pr_warn("%s() called, with CONFIG_MEMORY_HOTPLUG disabled\n", func);
>    226		dump_stack();
>    227		return -ENOSYS;
>    228	}
> 

After "grep -rn pr_fmt * | grep define" under arch/, for me, it is
blackfin's issue:

  we need use

    #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

  instead of

    #define pr_fmt(fmt) "module %s: " fmt, mod->name

I shall send one blackfin patch for it.

Thanks.
-- 
Chen Gang (陈刚)

Managing Natural Environments is the Duty of Human Beings.