linux-kernel - Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160610093922.GR5242@lukather>
Date:	Fri, 10 Jun 2016 11:39:22 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	luoyi.ly@...il.com
Cc:	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	linux@...linux.org.uk, wens@...e.org, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for
 Bananapi M1 Plus board

On Fri, Jun 03, 2016 at 02:13:36PM +0800, luoyi.ly@...il.com wrote:
> From: Luo Yi <luoyi.ly@...il.com>
> 
> Remove the extra empty line and add signed off. 
> 
> Signed-off-by: Luo Yi <luoyi.ly@...il.com>

Please send a new patch.

> ---
>  arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> index 6fd55d7..f9063ba 100644
> --- a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> @@ -47,7 +47,6 @@
>  	compatible = "sinovoip,bpi-m1-plus", "allwinner,sun7i-a20";
>  };
>  
> -
>  &codec {
>  	status = "okay";
>  };
> @@ -62,11 +61,8 @@
>  		interrupts = <7 15 IRQ_TYPE_LEVEL_LOW>; 
>  		interrupt-names = "host-wake";
>  	};
> -
>  };
>  
>  &mmc3_pins_a {
> -    /* AP6210 requires pull-up */

And that comment was fine, why did you remove it?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)