linux-kernel - Re: [PATCH v3 1/2] power: axp288_charger: Replace deprecatd API of extcon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <575A1D2C.5060101@samsung.com>
Date:	Fri, 10 Jun 2016 10:51:40 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	Sebastian Reichel <sre@...nel.org>
Cc:	dbaryshkov@...il.com, dwmw2@...radead.org, wens@...e.org,
	myungjoo.ham@...sung.com, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] power: axp288_charger: Replace deprecatd API of
 extcon

Hi,

On 2016년 06월 10일 10:46, Sebastian Reichel wrote:
> Hi,
> 
> On Tue, May 31, 2016 at 06:34:39PM +0900, Chanwoo Choi wrote:
>> This patch removes the deprecated notifier API of extcon framework and then use
>> the new extcon API[2] with the unique id[1] to indicate the each external
>> connector. Alter deprecated API as following:
>> - extcon_register_interest() -> extcon_register_notifier()
>> - extcon_unregister_interest() -> extcon_unregister_notifier()
>> - extcon_get_cable_state() -> extcon_get_cable_state_()
>>
>> And, extcon alters the name of USB charger connector in patch[3] as following:
>> - EXTCON_CHG_USB_SDP /* Standard Downstream Port */
>> - EXTCON_CHG_USB_DCP /* Dedicated Charging Port */
>> - EXTCON_CHG_USB_CDP /* Charging Downstream Port */
>> - EXTCON_CHG_USB_ACA /* Accessory Charger Adapter */
>>
>> [1] Commit 2a9de9c0f08d61
>> - ("extcon: Use the unique id for external connector instead of string)
>> [2] Commit 046050f6e623e4
>> - ("extcon: Update the prototype of extcon_register_notifier() with enum extcon
>> [3] Commit 11eecf910bd81d
>> - ("extcon: Modify the id and name of external connector")
>>
>> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
>> ---
>>  drivers/power/axp288_charger.c | 77 +++++++++++++++++++++++++++++-------------
>>  1 file changed, 53 insertions(+), 24 deletions(-)
> 
> Acked-By: Sebastian Reichel <sre@...nel.org>
> 

To prevent the build error on linux-next, this patchset should be merged on one repository.
So, I think that there are two solution.
First, I'll make the immutable branch for them and send pull request to you.
Second, I'll apply this patchset on extcon git repository.

Which would you prefer? If you answer, I'll do right now.

Thanks,
Chanwoo Choi