linux-kernel - Re: [PATCH v2 6/6] drm/panel: simple: Add support for Sharp LQ123P1JX31 2400x1600 panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=Vmh-weKJLdDY=zfLRL9bMzDGvSV5gN=jaRV3d-b+jxiw@mail.gmail.com>
Date:	Fri, 10 Jun 2016 09:11:30 -0700
From:	Doug Anderson <dianders@...omium.org>
To:	Yakir Yang <ykk@...k-chips.com>
Cc:	David Airlie <airlied@...ux.ie>,
	Thierry Reding <thierry.reding@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Kumar Gala <galak@...eaurora.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 6/6] drm/panel: simple: Add support for Sharp
 LQ123P1JX31 2400x1600 panel

Hi,

On Wed, Jun 8, 2016 at 9:35 AM, Doug Anderson <dianders@...omium.org> wrote:
> Yakir,
>
> On Wed, Jun 8, 2016 at 4:52 AM, Yakir Yang <ykk@...k-chips.com> wrote:
>> The Sharp LQ123P1JX31 is an 12.3", 2400x1600 TFT-LCD panel connected
>> using eDP interfaces.
>>
>> Signed-off-by: Yakir Yang <ykk@...k-chips.com>
>> ---
>> Changes in v2:
>> - Add detail timing of Sharp LQ123P1JX31 panel in v2
>>
>>  drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
>>  1 file changed, 26 insertions(+)
>
> Looks good to me.  Values in the table match the EDID I see from this
> panel and everything else looks to be in order.
>
> Reviewed-by: Doug Anderson <dianders@...omium.org>
> Tested-by: Doug Anderson <dianders@...omium.org>

Sorry for not noticing.  :(  ...but as others have pointed out for
your earlier patches, the size is incorrect.  I found the correct size
and it should be:

               .width = 259,
               .height = 173,


-Doug