linux-kernel - RE: [PATCH V4 2/3] i2c: qup: Fix wrong value of index variable

Open Source and information security mailing list archives

Message-ID: <00af01d1c344$1cd02310$56706930$@codeaurora.org>
Date:	Fri, 10 Jun 2016 23:45:37 +0530
From:	"Sricharan" <sricharan@...eaurora.org>
To:	<linux-arm-msm@...r.kernel.org>, <ntelkar@...eaurora.org>,
	<galak@...eaurora.org>, <linux-kernel@...r.kernel.org>,
	<andy.gross@...aro.org>, <linux-i2c@...r.kernel.org>,
	<agross@...eaurora.org>, <linux-arm-kernel@...ts.infradead.org>,
	<nkaje@...eaurora.org>, <absahu@...eaurora.org>,
	<wsa@...-dreams.de>
Subject: RE: [PATCH V4 2/3] i2c: qup: Fix wrong value of index variable

+Wolfram Sang

>-----Original Message-----
>From: linux-arm-kernel [mailto:linux-arm-kernel-bounces@...ts.infradead.org] On Behalf Of Sricharan R
>Sent: Friday, June 10, 2016 11:38 PM
>To: linux-arm-msm@...r.kernel.org; ntelkar@...eaurora.org; galak@...eaurora.org; linux-kernel@...r.kernel.org;
>andy.gross@...aro.org; linux-i2c@...r.kernel.org; agross@...eaurora.org; linux-arm-kernel@...ts.infradead.org;
>nkaje@...eaurora.org; absahu@...eaurora.org
>Cc: sricharan@...eaurora.org
>Subject: [PATCH V4 2/3] i2c: qup: Fix wrong value of index variable
>
>index gets incremented during check to determine if the
>messages can be transferred with dma. But not reset after
>that, resulting in wrong start value in subsequent loop,
>causing failure. Fix it.
>
>Signed-off-by: Sricharan R <sricharan@...eaurora.org>
>---
> drivers/i2c/busses/i2c-qup.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c
>index 43adc2d..b8116e5 100644
>--- a/drivers/i2c/busses/i2c-qup.c
>+++ b/drivers/i2c/busses/i2c-qup.c
>@@ -1260,6 +1260,8 @@ static int qup_i2c_xfer_v2(struct i2c_adapter *adap,
> 		}
> 	}
>
>+	idx = 0;
>+
> 	do {
> 		if (msgs[idx].len == 0) {
> 			ret = -EINVAL;
>--
>QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux
>Foundation
>
>
>_______________________________________________
>linux-arm-kernel mailing list
>linux-arm-kernel@...ts.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives