linux-kernel - Re: [PATCH] ARM: bcm2835: remove unused _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m27fdwy9rw.fsf@baylibre.com>
Date:	Fri, 10 Jun 2016 15:11:15 -0700
From:	Kevin Hilman <khilman@...libre.com>
To:	Eric Anholt <eric@...olt.net>
Cc:	Ben Dooks <ben.dooks@...ethink.co.uk>,
	linux-kernel@...ts.codethink.co.uk,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Alexander Aring <alex.aring@...il.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: bcm2835: remove unused __packet

Eric Anholt <eric@...olt.net> writes:

> Ben Dooks <ben.dooks@...ethink.co.uk> writes:
>
>> The driver defines a variable called __packet but then never
>> uses it, and does not export it for others to use either. Fix
>> the warning about undeclared variable by removing it.
>>
>> drivers/soc/bcm/raspberrypi-power.c:48:3: warning: symbol '__packet' was not declared. Should it be static?
>
> Reviewed-by: Eric Anholt <eric@...olt.net>
>
> PM folks: I'd be happy to see this go through your trees, but either way
> is fine with me.

Since this is in drivers/soc, just include it in your cleanup branch for
arm-soc.

Kevin