linux-kernel - Re: [Xen-devel] [PATCH 1/7] x86/xen: Simplify set_aliased

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrWpo+QmdQ2n-QMojb954-oGgfHP0FBVbn6n6iR-+y6cNQ@mail.gmail.com>
Date:	Fri, 10 Jun 2016 15:12:31 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	David Vrabel <david.vrabel@...rix.com>,
	Ingo Molnar <mingo@...nel.org>
Cc:	Andy Lutomirski <luto@...nel.org>, X86 ML <x86@...nel.org>,
	Kees Cook <keescook@...omium.org>,
	Brian Gerst <brgerst@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	xen-devel <xen-devel@...ts.xen.org>,
	Jan Beulich <jbeulich@...e.com>,
	Borislav Petkov <bp@...en8.de>,
	Andrew Cooper <andrew.cooper3@...rix.com>,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>
Subject: Re: [Xen-devel] [PATCH 1/7] x86/xen: Simplify set_aliased_prot

On Wed, May 25, 2016 at 2:50 AM, David Vrabel <david.vrabel@...rix.com> wrote:
> On 24/05/16 23:48, Andy Lutomirski wrote:
>> In aa1acff356bb ("x86/xen: Probe target addresses in
>> set_aliased_prot() before the hypercall"), I added an explicit probe
>> to work around a hypercall issue.  The code can be simplified by
>> using probe_kernel_read.
>
> Acked-by: David Vrabel <david.vrabel@...rix.com>

Ingo, can you apply this one patch directly to x86/asm?  The rest of
the series is stalled pending my fixing Borislav's review comments
and, more importantly, fixing the bugs that testing it has shaken
loose.  This patch is a nice cleanup all by itself, though.

--Andy