linux-kernel - Re: [PATCH 1/1] apparmor: do not expose kernel stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <575B3B98.5010606@canonical.com>
Date:	Fri, 10 Jun 2016 15:13:44 -0700
From:	John Johansen <john.johansen@...onical.com>
To:	Heinrich Schuchardt <xypron.glpk@....de>,
	James Morris <james.l.morris@...cle.com>,
	"Serge E. Hallyn" <serge@...lyn.com>
Cc:	linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] apparmor: do not expose kernel stack

On 06/10/2016 02:34 PM, Heinrich Schuchardt wrote:
> Do not copy uninitalized fields th.td_hilen, th.td_data.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@....de>

Acked-by: John Johansen <john.johansen@...onical.com>

I have a queue of patches I need to push this weekend so I
will suck this one in and send it up with the rest

> ---
>  security/apparmor/match.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/security/apparmor/match.c b/security/apparmor/match.c
> index 727eb42..1d6dbd8 100644
> --- a/security/apparmor/match.c
> +++ b/security/apparmor/match.c
> @@ -61,7 +61,9 @@ static struct table_header *unpack_table(char *blob, size_t bsize)
>  
>  	table = kvzalloc(tsize);
>  	if (table) {
> -		*table = th;
> +		table->td_id = th.td_id;
> +		table->td_flags = th.td_flags;
> +		table->td_lolen = th.td_lolen;
>  		if (th.td_flags == YYTD_DATA8)
>  			UNPACK_ARRAY(table->td_data, blob, th.td_lolen,
>  				     u8, byte_to_byte);
>