linux-kernel - [PATCH v4 0/1] pstore/ram: add Device Tree bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1465599059-22665-1-git-send-email-keescook@chromium.org>
Date:	Fri, 10 Jun 2016 15:50:58 -0700
From:	Kees Cook <keescook@...omium.org>
To:	linux-kernel@...r.kernel.org
Cc:	Kees Cook <keescook@...omium.org>,
	Greg Hackmann <ghackmann@...gle.com>,
	Arnd Bergmann <arnd@...db.de>,
	Rob Herring <robh+dt@...nel.org>,
	Markus Pargmann <mpa@...gutronix.de>,
	Olof Johansson <olof@...om.net>,
	Brian Norris <computersforpeace@...il.com>,
	Anton Vorontsov <anton@...msg.org>,
	Colin Cross <ccross@...roid.com>,
	Lee Campbell <leecam@...gle.com>,
	Tony Luck <tony.luck@...el.com>, devicetree@...r.kernel.org,
	linux-doc@...r.kernel.org
Subject: [PATCH v4 0/1] pstore/ram: add Device Tree bindings

This is a "v4" of Greg Hackmann's DT bindings for ramoops. This is
what I'm going to land in the pstore tree unless there are strong and
convincing arguments against it. :)

I made a number of changes based people's feedback, and I want to get
it unblocked. This patch is already carried by Android, and it doesn't
need to be out of tree.

To respond to Arnd's comment: I like this as the ramoops node, not the
pstore node, since it describes the ramoops backend, not the pstore
subsystem, which has different controls, and can only have one backend
at a time. So it doesn't make sense to me to have this have a redundant
extra pstore node, since the very presence of ramoops implies pstore.

Markus Pargmann's issues I think were well addressed by Rob Herring.

I simplified code by using Olof Johansson's suggestion to reduce the
parsing width to u32.

I added Brian Norris's crash fix.

Beyond that, I made whitespace changes, consolidated some code, fixed
some long lines, updated documentation, etc.

Hopefully this all looks good. Further testing would be appreciated. :)

Thanks!

-Kees