linux-kernel - Re: [PATCH perf/core v10 07/23] perf probe: Add --cache option to cache the probe definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160611083214.2a74a8490c4719a82040262f@kernel.org>
Date:	Sat, 11 Jun 2016 08:32:14 +0900
From:	Masami Hiramatsu <mhiramat@...nel.org>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:	linux-kernel@...r.kernel.org, Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	Hemant Kumar <hemant@...ux.vnet.ibm.com>,
	Ananth N Mavinakayanahalli <ananth@...ux.vnet.ibm.com>,
	Brendan Gregg <brendan.d.gregg@...il.com>
Subject: Re: [PATCH perf/core v10 07/23] perf probe: Add --cache option to
 cache the probe definitions

On Thu, 9 Jun 2016 11:18:50 -0300
Arnaldo Carvalho de Melo <acme@...nel.org> wrote:

> Em Wed, Jun 08, 2016 at 06:30:10PM +0900, Masami Hiramatsu escreveu:
> > @@ -2555,6 +2556,14 @@ static int __add_probe_trace_events(struct perf_probe_event *pev,
> >  	}
> >  	if (ret == -EINVAL && pev->uprobes)
> >  		warn_uprobe_event_compat(tev);
> > +	if (ret == 0 && probe_conf.cache) {
> > +		cache = probe_cache__new(pev->target);
> > +		if (cache) {
> > +			probe_cache__add_entry(cache, pev, tevs, ntevs);
> > +			probe_cache__commit(cache);
> 
> These two functions may fail, please check its return and forward errors
> appropriately.

OK, will check and warn that.

Thank you!
-- 
Masami Hiramatsu <mhiramat@...nel.org>