linux-kernel - Re: [PATCH] PCI: host-generic: select IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160611000015.GC16462@localhost>
Date:	Fri, 10 Jun 2016 19:00:16 -0500
From:	Bjorn Helgaas <helgaas@...nel.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>,
	Marc Zyngier <marc.zyngier@....com>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: host-generic: select IRQ_DOMAIN

On Wed, May 18, 2016 at 04:15:53PM +0200, Arnd Bergmann wrote:
> The generic PCI host controller calls of_irq_parse_and_map_pci
> in its IRQ fixup, but that function is only available when
> CONFIG_IRQ_DOMAIN is set:
> 
> drivers/pci/built-in.o: In function `pci_host_common_probe':
> drivers/pci/host/pci-host-common.c:181: undefined reference to `of_irq_parse_and_map_pci'
> 
> There is no downside in enabling the domains here, so let's
> use a Kconfig select statement to ensure it's always available
> to this driver.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied to pci/host-generic for v4.8, thanks, Arnd.

> ---
>  drivers/pci/host/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index 66329b932e29..64734ba070a2 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -87,6 +87,7 @@ config PCI_HOST_GENERIC
>  	bool "Generic PCI host controller"
>  	depends on (ARM || ARM64) && OF
>  	select PCI_HOST_COMMON
> +	select IRQ_DOMAIN
>  	help
>  	  Say Y here if you want to support a simple generic PCI host
>  	  controller, such as the one emulated by kvmtool.
> -- 
> 2.7.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html