linux-kernel - Re: [PATCH] phy: marvell: fix LED configuration via marvell,reg-init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160611154714.GQ2338@lunn.ch>
Date:	Sat, 11 Jun 2016 17:47:14 +0200
From:	Andrew Lunn <andrew@...n.ch>
To:	Clemens Gruber <clemens.gruber@...ruber.com>
Cc:	netdev@...r.kernel.org, Florian Fainelli <f.fainelli@...il.com>,
	linux-kernel@...r.kernel.org,
	"David S . Miller" <davem@...emloft.net>,
	Sergei Poselenov <sposelenov@...raft.com>
Subject: Re: [PATCH] phy: marvell: fix LED configuration via marvell,reg-init

On Sat, Jun 11, 2016 at 05:21:26PM +0200, Clemens Gruber wrote:
> Configuring the PHY LED registers for the Marvell 88E1510 and others is
> not possible, because regardless of the values in marvell,reg-init, it
> is later overridden in m88e1121_config_aneg with a non-standard default.
> 
> This patch moves that default configuration to .config_init to allow
> setting the LED configuration through marvell,reg-init in the device
> tree, which should override said default if it exists.
> 
> Signed-off-by: Clemens Gruber <clemens.gruber@...ruber.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew