linux-kernel - Re: [PATCH] staging: iio: fix ad7606

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0e594d6f-d228-030c-7670-3a40459c6ab9@kernel.org>
Date:	Sat, 11 Jun 2016 17:58:01 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Arnd Bergmann <arnd@...db.de>
Cc:	Lars-Peter Clausen <lars@...afoo.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Ksenija Stanojevic <ksenija.stanojevic@...il.com>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Hartmut Knaack <knaack.h@....de>,
	Peter Meerwald-Stadler <pmeerw@...erw.net>,
	Ioana Ciornei <ciorneiioana@...il.com>,
	Daniel Baluta <daniel.baluta@...el.com>,
	linux-iio@...r.kernel.org,
	driverdevel <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: iio: fix ad7606_spi regression

On 30/05/16 14:54, Geert Uytterhoeven wrote:
> On Mon, May 30, 2016 at 3:50 PM, Arnd Bergmann <arnd@...db.de> wrote:
>> As pointed out by Geert Uytterhoeven, the patch was incorrect
>> and breaks the driver, which was fortunately pointed out by
>> this gcc warning:
>>
>> drivers/staging/iio/adc/ad7606_spi.c: In function ‘ad7606_spi_read_block’:
>> drivers/staging/iio/adc/ad7606_spi.c:34: warning: ‘data’ is used uninitialized in this function
>>
>> The effect of the patch is that the data is copied into
>> a random memory location (from the uninitialized pointer)
>> instead of being byteswapped in place.
>>
>> This adds the initialization for the 'data' variable back
>> to restore the original behavior.
>>
>> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
>> Cc: Ksenija Stanojevic <ksenija.stanojevic@...il.com>
>> Fixes: 87787e5ef727 ("Staging: iio: Fix sparse endian warning")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>
Applied to the fixes-togreg branch of iio.git

Thanks,

Jonathan
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
>