linux-kernel - Re: [PATCH v2 07/17] sh: Passing FDT address on zImage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0e0cfaed-6109-c98f-02b8-99d9199ef2db@cogentembedded.com>
Date:	Sun, 12 Jun 2016 14:38:46 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Yoshinori Sato <ysato@...rs.sourceforge.jp>,
	linux-sh@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 07/17] sh: Passing FDT address on zImage

On 6/12/2016 9:54 AM, Yoshinori Sato wrote:

> Signed-off-by: Yoshinori Sato <ysato@...rs.sourceforge.jp>
> ---
>  arch/sh/boot/compressed/head_32.S | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/sh/boot/compressed/head_32.S b/arch/sh/boot/compressed/head_32.S
> index 3e15032..ef70454 100644
> --- a/arch/sh/boot/compressed/head_32.S
> +++ b/arch/sh/boot/compressed/head_32.S
> @@ -11,10 +11,11 @@
>
>  	.global	startup
>  startup:
> +	/* Save FDT address */
> +	mov	r4, r13
>  	/* Load initial status register */
>  	mov.l   init_sr, r1
>  	ldc     r1, sr
> -
>  	/* Move myself to proper location if necessary */
>  	mova	1f, r0
>  	mov.l	1f, r2
> @@ -83,7 +84,7 @@ l1:
>  	/* Jump to the start of the decompressed kernel */
>  	mov.l	kernel_start_addr, r0
>  	jmp	@r0
> -	nop
> +	  mov	r13,r4

    Forgot a space after comma?
    Is it a delay slot BTW (judging by extra indentation)?

[...]

MBR, Sergei