linux-kernel - Re: [PATCH 07/11] clk: imx6ul: fix pll clock parents

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160612115204.GB32690@shlinux2>
Date:	Sun, 12 Jun 2016 19:52:04 +0800
From:	Dong Aisheng <dongas86@...il.com>
To:	Shawn Guo <shawnguo@...nel.org>
Cc:	Dong Aisheng <aisheng.dong@....com>, linux-clk@...r.kernel.org,
	anson.huang@....com, mturquette@...libre.com, sboyd@...eaurora.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 07/11] clk: imx6ul: fix pll clock parents

On Sun, Jun 12, 2016 at 07:43:53PM +0800, Shawn Guo wrote:
> On Wed, Jun 08, 2016 at 10:33:36PM +0800, Dong Aisheng wrote:
> > pllx_bypass_src mux shouldn't be the parent of pllx clock
> > since it's only valid when when pllx BYPASS bit is set.
> > Thus it is actually one parent of pllx_bypass only.
> > 
> > Instead, pllx parent should be fixed to osc according to
> > reference manual.
> > Other plls have the same issue.
> > 
> > e.g. before fix, the pll tree is:
> > osc                                      6            6    24000000          0 0
> >    pll1_bypass_src                       0            0    24000000          0 0
> >       pll1                               0            0   792000000          0 0
> >          pll1_bypass                     0            0   792000000          0 0
> >             pll1_sys                     0            0   792000000          0 0
> > 
> > After the fix, it's:
> > osc                                      6            6    24000000          0 0
> >    pll1                                  0            0   792000000          0 0
> >       pll1_bypass                        0            0   792000000          0 0
> >          pll1_sys                        0            0   792000000          0 0
> > 
> > Signed-off-by: Dong Aisheng <aisheng.dong@....com>
> 
> I squashed 7 ~ 11 into one patch and applied it, thanks.
> 

I'm fine.
Thanks

Regards
Dong Aisheng

> Shawn
> --
> To unsubscribe from this list: send the line "unsubscribe linux-clk" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html