lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 12 Jun 2016 22:56:38 +0800 From: Dong Aisheng <dongas86@...il.com> To: Dong Aisheng <aisheng.dong@....com> Cc: linux-clk@...r.kernel.org, anson.huang@....com, Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...eaurora.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Shawn Guo <shawnguo@...nel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH 01/11] clk: imx: clk-pllv3: fix incorrect handle of enet powerdown bit Hi Shawn, On Wed, Jun 8, 2016 at 10:33 PM, Dong Aisheng <aisheng.dong@....com> wrote: > After commit f53947456f98 ("ARM: clk: imx: update pllv3 to support imx7"), > the former used BM_PLL_POWER bit is not correct anymore for IMX7 ENET. > Instead, pll->powerdown holds the correct bit, so using powerdown bit > in clk_pllv3_{prepare | unprepare} functions. > > Fixes: f53947456f98 ("ARM: clk: imx: update pllv3 to support imx7") > Signed-off-by: Dong Aisheng <aisheng.dong@....com> Any comments about this one? Regards Dong Aisheng > --- > drivers/clk/imx/clk-pllv3.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c > index 4826b3c9e19e..44d294a336f0 100644 > --- a/drivers/clk/imx/clk-pllv3.c > +++ b/drivers/clk/imx/clk-pllv3.c > @@ -77,9 +77,9 @@ static int clk_pllv3_prepare(struct clk_hw *hw) > > val = readl_relaxed(pll->base); > if (pll->powerup_set) > - val |= BM_PLL_POWER; > + val |= pll->powerdown; > else > - val &= ~BM_PLL_POWER; > + val &= ~pll->powerdown; > writel_relaxed(val, pll->base); > > return clk_pllv3_wait_lock(pll); > @@ -92,9 +92,9 @@ static void clk_pllv3_unprepare(struct clk_hw *hw) > > val = readl_relaxed(pll->base); > if (pll->powerup_set) > - val &= ~BM_PLL_POWER; > + val &= ~pll->powerdown; > else > - val |= BM_PLL_POWER; > + val |= pll->powerdown; > writel_relaxed(val, pll->base); > } > > -- > 1.9.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@...ts.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Powered by blists - more mailing lists