linux-kernel - Re: [PATCH] coccicheck: Allow for overriding spatch flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92dd8f8e-7ee1-42df-66c9-95d8cca7210f@imag.fr>
Date:	Sun, 12 Jun 2016 23:38:08 +0200
From:	"Nicolas Palix (LIG)" <Nicolas.Palix@...g.fr>
To:	Deepa Dinamani <deepa.kernel@...il.com>,
	linux-kernel@...r.kernel.org
Cc:	Arnd Bergmann <arnd@...db.de>, Julia Lawall <Julia.Lawall@...6.fr>,
	Gilles Muller <Gilles.Muller@...6.fr>,
	Michal Marek <mmarek@...e.com>
Subject: Re: [PATCH] coccicheck: Allow for overriding spatch flags

Le 12/06/16 à 21:04, Deepa Dinamani a écrit :
> Documentation/coccinelle.txt suggests using the SPFLAGS
> make variable to pass additional options to spatch.
>
> Reorder the way SPFLAGS is added to FLAGS, to allow
> for options in the SPFLAGS to override the default
> --very-quiet option.
>
> Similarly, rearrage the FLAGS for org or report mode.
> This allows for overriding of the default --no-show-diff
> option through SPFLAGS.
>
> Signed-off-by: Deepa Dinamani <deepa.kernel@...il.com>
> Cc: Julia Lawall <Julia.Lawall@...6.fr>
> Cc: Gilles Muller <Gilles.Muller@...6.fr>
> Cc: Nicolas Palix <nicolas.palix@...g.fr>
Acked-By: Nicolas Palix <nicolas.palix@...g.fr>
> Cc: Michal Marek <mmarek@...e.com>
> ---
>  scripts/coccicheck | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index dd85a45..f662786 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -25,7 +25,7 @@ else
>  	NPROC="$J"
>  fi
>
> -FLAGS="$SPFLAGS --very-quiet"
> +FLAGS="--very-quiet $SPFLAGS"
>
>  # spatch only allows include directories with the syntax "-I include"
>  # while gcc also allows "-Iinclude" and "-include include"
> @@ -72,7 +72,7 @@ if [ "$MODE" = "chain" ] ; then
>  	echo 'All available modes will be tried (in that order): patch, report, context, org'
>      fi
>  elif [ "$MODE" = "report" -o "$MODE" = "org" ] ; then
> -    FLAGS="$FLAGS --no-show-diff"
> +    FLAGS="--no-show-diff $FLAGS"
>  fi
>
>  if [ "$ONLINE" = "0" ] ; then
>


-- 
Nicolas Palix
http://lig-membres.imag.fr/palix/


Download attachment "smime.p7s" of type "application/pkcs7-signature" (2959 bytes)