linux-kernel - RE: [PATCH] fbcon: warn on invalid cursor blink intervals

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 12 Jun 2016 05:05:27 +0000
From:	"Chintakuntla, Radha" <Radha.Chintakuntla@...ium.com>
To:	Henrique de Moraes Holschuh <hmh@....eng.br>,
	Scot Doyle <lkml14@...tdoyle.com>
CC:	Tomi Valkeinen <tomi.valkeinen@...com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jeremy Kerr <jk@...abs.org>, Ming Lei <ming.lei@...onical.com>,
	"Daney, David" <David.Daney@...ium.com>,
	Dann Frazier <dann.frazier@...onical.com>,
	Peter Hurley <peter@...leysoftware.com>,
	Pavel Machek <pavel@....cz>, Jonathan Liu <net147@...il.com>,
	Alistair Popple <alistair@...ple.id.au>,
	Jean-Philippe Brucker <jean-philippe.brucker@....com>,
	Jiri Slaby <jslaby@...e.com>, David Airlie <airlied@...ux.ie>,
	David Daney <ddaney.cavm@...il.com>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	stable <stable@...r.kernel.org>,
	"Chintakuntla, Radha" <Radha.Chintakuntla@...ium.com>
Subject: RE: [PATCH] fbcon: warn on invalid cursor blink intervals


> -----Original Message-----
> From: Henrique de Moraes Holschuh [mailto:hmh@....eng.br]
> Sent: Saturday, May 28, 2016 4:49 AM
> To: Scot Doyle <lkml14@...tdoyle.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@...com>; Jean-Christophe Plagniol-
> Villard <plagnioj@...osoft.com>; Greg Kroah-Hartman
> <gregkh@...uxfoundation.org>; Jeremy Kerr <jk@...abs.org>; Ming Lei
> <ming.lei@...onical.com>; Daney, David <David.Daney@...ium.com>;
> Dann Frazier <dann.frazier@...onical.com>; Peter Hurley
> <peter@...leysoftware.com>; Pavel Machek <pavel@....cz>; Jonathan Liu
> <net147@...il.com>; Alistair Popple <alistair@...ple.id.au>; Jean-Philippe
> Brucker <jean-philippe.brucker@....com>; Chintakuntla, Radha
> <Radha.Chintakuntla@...ium.com>; Jiri Slaby <jslaby@...e.com>; David
> Airlie <airlied@...ux.ie>; David Daney <ddaney.cavm@...il.com>; dri-
> devel@...ts.freedesktop.org; linux-fbdev@...r.kernel.org; Linux Kernel
> Mailing List <linux-kernel@...r.kernel.org>; stable
> <stable@...r.kernel.org>
> Subject: Re: [PATCH] fbcon: warn on invalid cursor blink intervals
> 
> On Fri, 20 May 2016, Scot Doyle wrote:
> > On Fri, 20 May 2016, Jeremy Kerr wrote:
> > > >Then looks there are two fix patches acked & tested:
> > > >
> > > > - the patch in this thread
> > > > - another one "[PATCH] tty: vt: Fix soft lockup in fbcon cursor
> > > >blink timer."
> > > > https://lkml.org/lkml/2016/5/17/455
> > > >
> > > >So which one will be pushed to linus?
> > >
> > > Not that it's my call, but we may want both; the first as a safety
> > > measure to prevent an invalid cur_blink_jiffies ever being set, and the
> > > second one to actually fix the initialisation of vc_cur_blink_ms (and
> > > address the warning introduced by the first).
> >
> > Tomi / Greg,
> >
> > I'd suggest
> > - applying "tty: vt: Fix soft lockup in fbcon cursor blink timer." to 4.7 and
> stable[4.2]
> > - applying "fbcon: warn on invalid cursor blink intervals" to 4.7
> > - ignoring "fbcon: use default if cursor blink interval is not valid"
> >
> > Note: the patches don't depend on each other
> 
> I applied both recommended patches on top of 4.4.11 for testing, and they
> made things a lot better here.
> 
> I suggest the second patch should be backported to stable too, might as well
> fix this thing for good *and keep the door closed*.

Is this patch available on some tree so that I can point to ?
And hope it will make it to linux-next soon ?

> 
> --
>   "One disk to rule them all, One disk to find them. One disk to bring
>   them all and in the darkness grind them. In the Land of Redmond
>   where the shadows lie." -- The Silicon Valley Tarot
>   Henrique Holschuh