linux-kernel - Re: [very-RFC 5/8] Add TSN machinery to drive the traffic from a shim over the network

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 12 Jun 2016 00:35:10 -0700
From:	Joe Perches <joe@...ches.com>
To:	Henrik Austad <henrik@...tad.us>, linux-kernel@...r.kernel.org
Cc:	linux-media@...r.kernel.org, alsa-devel@...r.kernel.org,
	linux-netdev@...r.kernel.org, henrk@...tad.us,
	Henrik Austad <haustad@...co.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [very-RFC 5/8] Add TSN machinery to drive the traffic from a
 shim over the network

On Sun, 2016-06-12 at 00:22 +0200, Henrik Austad wrote:
> From: Henrik Austad <haustad@...co.com>
> 
> In short summary:
> 
> * tsn_core.c is the main driver of tsn, all new links go through
>   here and all data to/form the shims are handled here
>   core also manages the shim-interface.
[]
> diff --git a/net/tsn/tsn_configfs.c b/net/tsn/tsn_configfs.c
[]
> +static inline struct tsn_link *to_tsn_link(struct config_item *item)
> +{
> +	/* this line causes checkpatch to WARN. making checkpatch happy,
> +	 * makes code messy..
> +	 */
> +	return item ? container_of(to_config_group(item), struct tsn_link, group) : NULL;
> +}

How about

static inline struct tsn_link *to_tsn_link(struct config_item *item)
{
	if (!item)
		return NULL;
	return container_of(to_config_group(item), struct tsn_link, group);
}