linux-kernel - Re: [PATCH 3/4] mtd: nand: Add support for Evatronix NANDFLASH-CTRL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1606130913400.29701@lnxricardw1.se.axis.com>
Date:	Mon, 13 Jun 2016 09:19:44 +0200
From:	Ricard Wanderlof <ricard.wanderlof@...s.com>
To:	Boris Brezillon <boris.brezillon@...e-electrons.com>
CC:	Mychaela Falconia <mychaela.falconia@...il.com>,
	<devicetree@...r.kernel.org>, Tony Lindgren <tony@...mide.com>,
	<linux-kernel@...r.kernel.org>,
	Oleksij Rempel <linux@...pel-privat.de>,
	Linux mtd <linux-mtd@...ts.infradead.org>,
	Benoit Cousson <bcousson@...libre.com>,
	Brian Norris <computersforpeace@...il.com>,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH 3/4] mtd: nand: Add support for Evatronix
 NANDFLASH-CTRL


On Fri, 10 Jun 2016, Boris Brezillon wrote:

> > Something that I am mildly miffed about is that I've posted this driver 
> > twice before on the mtd list (although, admittedly, not directly addressed 
> > to any maintainer), first as an RFC and later as a complete patch, without 
> > a single response. (Apparently Boris you did respond with comments on 
> > Oleksij's driver though which I must have missed). Although an RFC might 
> > not have initiated a detailed review, it would have been a large advantage 
> > (and wasted less time for all) if the point of using 'wrong' driver 
> > interface had been brought up and consequently discussed earlier. Yes I 
> > know, everyone is busy, it's easy to miss things, each and every driver 
> > can't be reviewed in detail, etc.
> 
> Yes, I know. I was not maintainer at that time, and was only reviewing
> a few patches from time to time.
> Now that I am, I try to answer as fast as possible. Note that the set
> of requirements might have change with me, so even if someone add
> agreed on you first submission but not taken the patches, I would have
> required the same set of changes ;).

:-)

Well, I'm not questioning that changes are required, and I'm happy to 
implement them once I've come to a clear understanding of what is needed, 
I just would have liked to known about them earlier, especially the major 
concepts.

I know there was probably no one interested enough at the time, everyone 
is busy, not every idea presented can be reviewed in detail etc etc. And 
it's not a big issue, just a minor annoyance.

/Ricard
-- 
Ricard Wolf Wanderlöf                           ricardw(at)axis.com
Axis Communications AB, Lund, Sweden            www.axis.com
Phone +46 46 272 2016                           Fax +46 46 13 61 30