linux-kernel - Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c74951dc-dbbe-3a75-a31b-a1c303520b4b@redhat.com>
Date:	Mon, 13 Jun 2016 09:55:56 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Wanpeng Li <kernellwp@...il.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	kvm <kvm@...r.kernel.org>, Wanpeng Li <wanpeng.li@...mail.com>,
	Ingo Molnar <mingo@...nel.org>,
	"Peter Zijlstra (Intel)" <peterz@...radead.org>,
	Rik van Riel <riel@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Radim Krčmář <rkrcmar@...hat.com>
Subject: Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full
 dynticks CPU time accounting



On 13/06/2016 05:38, Wanpeng Li wrote:
> + delta_jiffies = jiffies_to_cputime(now - tsk->vtime_snap);
> + steal_jiffies = jiffies_to_cputime(steal_account_process_tick(delta_jiffies));

Without jiffies_to_cputime here.  Apart from this, yes, this is what I
meant.

Paolo

>   WARN_ON_ONCE(tsk->vtime_snap_whence == VTIME_INACTIVE);
>   tsk->vtime_snap = now;
> 
> - return jiffies_to_cputime(delta);
> + return jiffies_to_cputime(delta_jiffies - steal_jiffies);