linux-kernel - linux-4.7-rc3/drivers/gpu/drm/amd/amdgpu/gfx_v7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMzoamaeEJzDXJ4r5Gp4Y15NZOVCcUx==SyYL9s7mT3183LHaw@mail.gmail.com>
Date:	Mon, 13 Jun 2016 09:16:24 +0100
From:	David Binderman <linuxdev.baldrick@...il.com>
To:	alexander.deucher@....com, christian.koenig@....com,
	airlied@...ux.ie, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org, dcb314@...mail.com
Subject: linux-4.7-rc3/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:4836: wierd
 condition ?

Hello there,

linux-4.7-rc3/drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:4836]: (style)
Boolean result is used in bitwise operation. Clarify expression with
parentheses.

Source code is

            if ((ring->me == me_id) & (ring->pipe == pipe_id))

Maybe better code

            if ((ring->me == me_id) && (ring->pipe == pipe_id))

Also in the same file:

[drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:3866]: (style) Variable 'data'
is assigned a value that is never used.
[drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:4321]: (style) Variable
'mc_shared_chmap' is assigned a value that is never used.
[drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:4657]: (style) Variable 'tmp'
is assigned a value that is never used.

Regards

David Binderman