linux-kernel - Re: [PATCH] Input: axp20x-pek: use devm_add_action_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGb2v67dj9wLcvknmQ5v7gaqBpBLg8d=5gM6i7JcQBfaefVf2g@mail.gmail.com>
Date:	Mon, 13 Jun 2016 11:53:15 +0800
From:	Chen-Yu Tsai <wens@...e.org>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Chen-Yu Tsai <wens@...e.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>
Subject: Re: [PATCH] Input: axp20x-pek: use devm_add_action_or_reset

On Sun, Jun 12, 2016 at 10:12 PM, Sudip Mukherjee
<sudipm.mukherjee@...il.com> wrote:
> If devm_add_action() fails we are explicitly calling
> axp20x_remove_sysfs_group() to free the resources allocated. Lets use
> the helper devm_add_action_or_reset() and return directly in case of
> error, as we know that the cleanup function has been already called by
> the helper if there was any error.
>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>

Acked-by: Chen-Yu Tsai <wens@...e.org>