linux-kernel - Re: [PATCH v5 00/11] serial: 8250: split LPSS to 8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1465816577.30123.8.camel@linux.intel.com>
Date:	Mon, 13 Jun 2016 14:16:17 +0300
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Bryan O'Donoghue <pure.logic@...us-software.ie>,
	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	Peter Hurley <peter@...leysoftware.com>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	Vinod Koul <vinod.koul@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	dmaengine <dmaengine@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Puustinen, Ismo" <ismo.puustinen@...el.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Subject: Re: [PATCH v5 00/11] serial: 8250: split LPSS to 8250_lpss, enable
 DMA on Quark

On Sun, 2016-06-12 at 18:13 +0100, Bryan O'Donoghue wrote:
> On Tue, 2016-06-07 at 13:04 +0300, Andy Shevchenko wrote:
> > > I'll find some time to look at both a short stream and a long
> > stream,
> > > based on the branch you've indicated and maybe against the latest
> > > stable kernel.
> > 
> > Please, do. I'm planning to resend new version soon (this week or
> > lately beginning of the next one).
> 
> So.
> 
> Generally DMA appears to make little-to-no difference here.

Yes, because your test shows the speed of the serial data line.

What we are trying to measure here?

If you would like to measure CPU load it will require threaded
application and some load task to see the difference. Another metric
which may help is interrupt counters. I'm wondering if perf can help
here as well.

> One thing I have noticed is that the following never completes and
> can't be reset back to mode=0 or mode=3 to restore functionality -
> definitely worth looking at if you are spinning another patch.
> 
> ### never completes ####
> root@...ileo:~# echo 1 > /sys/class/tty/ttyS0/dma_mode
> root@...ileo:~# stty -F /dev/ttyS0 921600
> root@...ileo:~# time cat tester.txt > /dev/ttyS0
> ### never completes ####

Thanks for that test, I will try to reproduce on my side.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy