linux-kernel - Re: [patch 06/20] drivers/tty/metag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADyApD0UcWnMBGh9Fu5Wj6M08hNAZ7R-YJXqFjsNtGrBihieAA@mail.gmail.com>
Date:	Mon, 13 Jun 2016 06:13:50 -0700
From:	Arjan van de Ven <arjanvandeven@...il.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Chris Mason <clm@...com>,
	Arjan van de Ven <arjan@...radead.org>, rt@...utronix.de
Subject: Re: [patch 06/20] drivers/tty/metag_da: Initialize timer as pinned

I know it's not related to this patch, but it'd be nice to, as you're
changing the api name anyway, make a mod_pinned_relative() so that
more direct users of jiffies can go away...
or even better, mod_pinned_relative_ms() so that these drivers also do
not need to care about HZ.

On Mon, Jun 13, 2016 at 1:40 AM, Thomas Gleixner <tglx@...utronix.de> wrote:
> Pinned timers must carry that attribute in the timer itself. No functional
> change.
>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> ---
>  drivers/tty/metag_da.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: b/drivers/tty/metag_da.c
> ===================================================================
> --- a/drivers/tty/metag_da.c
> +++ b/drivers/tty/metag_da.c
> @@ -323,12 +323,12 @@ static void dashtty_timer(unsigned long
>         if (channel >= 0)
>                 fetch_data(channel);
>
> -       mod_timer_pinned(&poll_timer, jiffies + DA_TTY_POLL);
> +       mod_pinned(&poll_timer, jiffies + DA_TTY_POLL);
>  }
>
>  static void add_poll_timer(struct timer_list *poll_timer)
>  {
> -       setup_timer(poll_timer, dashtty_timer, 0);
> +       setup_pinned_timer(poll_timer, dashtty_timer, 0);
>         poll_timer->expires = jiffies + DA_TTY_POLL;
>
>         /*
>
>