linux-kernel - Re: [PATCH] ceph: fix symbol versioning for ceph_monc_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOi1vP9twC4r6wwuHV0FAcwBoYhELfdrLjjAfNDzMh==akKeJQ@mail.gmail.com>
Date:	Mon, 13 Jun 2016 15:19:12 +0200
From:	Ilya Dryomov <idryomov@...il.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Sage Weil <sage@...hat.com>, Jan Beulich <jbeulich@...e.com>,
	Michal Marek <mmarek@...e.cz>, "Yan, Zheng" <zyan@...hat.com>,
	Alex Elder <elder@...aro.org>,
	Ceph Development <ceph-devel@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ceph: fix symbol versioning for ceph_monc_do_statfs

On Mon, Jun 13, 2016 at 3:04 PM, Arnd Bergmann <arnd@...db.de> wrote:
> The genksyms helper in the kernel cannot parse a type definition
> like "typeof(((type *)0)->keyfld)" that is used in the DEFINE_RB_FUNCS
> helper, causing the following EXPORT_SYMBOL() statement to be ignored
> when computing the crcs, and triggering a warning about this:
>
> WARNING: "ceph_monc_do_statfs" [fs/ceph/ceph.ko] has no CRC
>
> To work around the problem, we can rewrite the type to reference
> an undefined 'extern' symbol instead of a NULL pointer. This is
> evidently ok for genksyms, and it no longer complains about the
> line when calling it with 'genksyms -w'.
>
> I've looked briefly into extending genksyms instead, but it seems
> really hard to do. Jan Beulich introduced basic support for 'typeof'
> a while ago in dc53324060f3 ("genksyms: fix typeof() handling"),
> but that is not sufficient for the expression we have here.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: fcd00b68bbe2 ("libceph: DEFINE_RB_FUNCS macro")
> Cc: Jan Beulich <jbeulich@...e.com>
> Cc: Michal Marek <mmarek@...e.cz>
> ---
>  include/linux/ceph/libceph.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/ceph/libceph.h b/include/linux/ceph/libceph.h
> index 690985daad1c..6b79a6ba39ca 100644
> --- a/include/linux/ceph/libceph.h
> +++ b/include/linux/ceph/libceph.h
> @@ -214,8 +214,9 @@ static void erase_##name(struct rb_root *root, type *t)                     \
>  }
>
>  #define DEFINE_RB_LOOKUP_FUNC(name, type, keyfld, nodefld)             \
> +extern type __lookup_##name##_key;                                     \
>  static type *lookup_##name(struct rb_root *root,                       \
> -                          typeof(((type *)0)->keyfld) key)             \
> +                          typeof(__lookup_##name##_key.keyfld) key)    \
>  {                                                                      \
>         struct rb_node *n = root->rb_node;                              \
>                                                                         \

Out of curiosity, did you figure out why is it that only
ceph_monc_do_statfs() is affected and not the other exports in
net/ceph/osd_client.c?

Thanks,

                Ilya