linux-kernel - Re: [alsa-devel] [PATCH] ASoC: intel: fix build when ACPI is not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <575ECB6C.7050102@infradead.org>
Date:	Mon, 13 Jun 2016 08:04:12 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Vinod Koul <vinod.koul@...el.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, alsa-devel@...a-project.org,
	Jie Yang <yang.jie@...ux.intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: intel: fix build when ACPI is not
 enabled

On 06/12/16 21:22, Vinod Koul wrote:
> On Thu, Jun 09, 2016 at 05:01:38PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@...radead.org>
>>
>> kconfig tools generate the following warning when CONFIG_ACPI is not
>> enabled:
>>
>> warning: (SND_SOC_INTEL_BYTCR_RT5640_MACH && SND_SOC_INTEL_BYTCR_RT5651_MACH && SND_SOC_INTEL_CHT_BSW_RT5672_MACH && SND_SOC_INTEL_CHT_BSW_RT5645_MACH && SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH) selects SND_SST_IPC_ACPI which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC && ACPI)
>>
>> causing these build errors:
>>
>> In file included from ../sound/soc/intel/atom/sst/sst_acpi.c:40:0:
>> ../include/acpi/acpi_bus.h:65:20: error: conflicting types for 'acpi_evaluate_dsm'
>>  union acpi_object *acpi_evaluate_dsm(acpi_handle handle, const u8 *uuid,
>> In file included from ../sound/soc/intel/atom/sst/sst_acpi.c:31:0:
>> ../include/linux/acpi.h:676:34: note: previous definition of 'acpi_evaluate_dsm' was here
>>  static inline union acpi_object *acpi_evaluate_dsm(acpi_handle handle,
>>
>> I am told that ACPI is a requirement for these drivers, so make that
>> explicit. Also end help text sentences with a period.
>>
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Cc:	Jie Yang <yang.jie@...ux.intel.com>
>> Cc:	Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
>> Cc:	alsa-devel@...a-project.org
>> ---
>>  sound/soc/intel/Kconfig |   12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> Should SND_SOC_INTEL_SST and possibly other similar drivers get this
>> same change?
> 
> The SND_SST_IPC_ACPI has depends on ACPI.
> 
> Can you send me your config for this.

Attached.

-- 
~Randy

View attachment "config-r9361" of type "text/plain" (92183 bytes)