linux-kernel - Re: [PATCH v2 2/2] ARM: dts: sd_600eval: Fix eMMC lockup issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 13 Jun 2016 17:21:16 +0100
From:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:	Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:	Andy Gross <andy.gross@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	David Brown <david.brown@...aro.org>,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	linux-soc@...r.kernel.org,
	Parth Pancholi <parth.pancholi@...fochips.com>
Subject: Re: [PATCH v2 2/2] ARM: dts: sd_600eval: Fix eMMC lockup issue



On 12/06/16 05:47, Bjorn Andersson wrote:
> On Fri 10 Jun 11:19 PDT 2016, Srinivas Kandagatla wrote:
>
>> From: Parth Pancholi <parth.pancholi@...fochips.com>
>>
>> This board locks up if we stress test the eMMC, as the regulator s4 is
>> unable to supply enough current for all the peripherials attached to it.
>> As this supply is wired up to most of the peripherials including DDR,
>> it resulted in such lockup.
>>
>> This patch fixes this issue by setting s4 regulator correctly with
>> Auto power mode.
>>
>> Reported-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
>> [Srinivas Kandagatla: rewrote the change log]
>> Tested-by: Girish Sharma <girish.sharma@...fochips.com>
>> Signed-off-by: Parth Pancholi <parth.pancholi@...fochips.com>
>
> If I read the msm-3.4 tree correctly most (perhaps all) 8064 devices
> should have this setup.
>
I agree, we should patch other boards as well with the same value.


> Acked-by: Bjorn Andersson <bjorn.andersson@...aro.org>

thanks,
srini
>
> Regards,
> Bjorn
>
>> ---
>>   arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts b/arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts
>> index 7df0108..39ae2bc 100644
>> --- a/arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts
>> +++ b/arch/arm/boot/dts/qcom-apq8064-arrow-sd-600eval.dts
>> @@ -1,6 +1,7 @@
>>   #include "qcom-apq8064-v2.0.dtsi"
>>   #include "qcom-apq8064-arrow-sd-600eval-pins.dtsi"
>>   #include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/mfd/qcom-rpm.h>
>>
>>   / {
>>   	model = "Arrow Electronics, APQ8064 SD_600eval";
>> @@ -82,7 +83,8 @@
>>   				s4 {
>>   					regulator-min-microvolt	= <1800000>;
>>   					regulator-max-microvolt	= <1800000>;
>> -					qcom,switch-mode-frequency = <3200000>;
>> +					qcom,switch-mode-frequency = <1600000>;
>> +					qcom,force-mode = <QCOM_RPM_FORCE_MODE_AUTO>;
>>   					bias-pull-down;
>>   					regulator-always-on;
>>   				};
>> --
>> 2.8.3
>>