linux-kernel - Re: [PATCH -next] rcutorture: Fix error return code in rcu_perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 13 Jun 2016 09:52:13 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	weiyj_lk@....com
Cc:	Josh Triplett <josh@...htriplett.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Lai Jiangshan <jiangshanlai@...il.com>,
	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] rcutorture: Fix error return code in
 rcu_perf_init()

On Mon, Jun 13, 2016 at 03:20:39PM +0000, weiyj_lk@....com wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> Fix to return a negative error code -ENOMEM from kcalloc() error
> handling case instead of 0, as done elsewhere in this function.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

Good eyes!  Queued for review and testing.

							Thanx, Paul

> ---
>  kernel/rcu/rcuperf.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c
> index 7b2dbdf..d38ab08 100644
> --- a/kernel/rcu/rcuperf.c
> +++ b/kernel/rcu/rcuperf.c
> @@ -638,8 +638,10 @@ rcu_perf_init(void)
>  		writer_durations[i] =
>  			kcalloc(MAX_MEAS, sizeof(*writer_durations[i]),
>  				GFP_KERNEL);
> -		if (!writer_durations[i])
> +		if (!writer_durations[i]) {
> +			firsterr = -ENOMEM;
>  			goto unwind;
> +		}
>  		firsterr = torture_create_kthread(rcu_perf_writer, (void *)i,
>  						  writer_tasks[i]);
>  		if (firsterr)
> 
>