linux-kernel - Re: [PATCH 2/2] acpi/pmic: Add opregion driver for Intel BXT WhiskeyCove PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160613173801.GA202077@worksta>
Date:	Mon, 13 Jun 2016 10:38:02 -0700
From:	Bin Gao <bin.gao@...ux.intel.com>
To:	Aaron Lu <aaron.lu@...el.com>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	ysiyer <yegnesh.s.iyer@...el.com>,
	Ajay Thomas <ajay.thomas.david.rajamanickam@...el.com>,
	Bin Gao <bin.gao@...el.com>
Subject: Re: [PATCH 2/2] acpi/pmic: Add opregion driver for Intel BXT
 WhiskeyCove PMIC

On Sun, Jun 12, 2016 at 10:13:33AM +0800, Aaron Lu wrote:
> Last time Paul suggests device_initcall instead of module_init here:
> 
> commit 75829dcf10862966f52716f2d67ac1c1b1eb486b
> Author: Paul Gortmaker <paul.gortmaker@...driver.com>
> Date:   Mon Feb 15 00:27:51 2016 -0500
> 
>     drivers/acpi: make pmic/intel_pmic_crc.c explicitly non-modular
> 
> Perhaps you should do the same.

Thanks Aaron's review.
I just sent out v2 of the patches which addressed your comments.