Message-ID: <20160613180338.29199-1-paul.gortmaker@windriver.com>
Date:	Mon, 13 Jun 2016 14:03:33 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	<linux-kernel@...r.kernel.org>
CC:	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Antoine Tenart <antoine.tenart@...e-electrons.com>,
	Joachim Eastwood <manabian@...il.com>,
	Masahiro Yamada <yamada.masahiro@...ionext.com>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Michal Simek <michal.simek@...inx.com>,
	Moritz Fischer <moritz.fischer@...us.com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Sören Brinkmann <soren.brinkmann@...inx.com>,
	Steffen Trumtrar <s.trumtrar@...gutronix.de>
Subject: [PATCH 0/5] reset: make non-modular drivers really non modular

For anyone new to the underlying goal of this cleanup, we are trying to
not use module support for code that can never be built as a module since:

 (1) it is easy to accidentally write unused module_exit and remove code
 (2) it can be misleading when reading the source, thinking it can be
     modular when the Makefile and/or Kconfig prohibit it
 (3) it requires the include of the module.h header file which in turn
     includes nearly everything else, thus adding to CPP overhead.
 (4) it gets copied/replicated into other code and spreads like weeds.

Fortunately the reset dir is in pretty good shape, and there are only
five instances of non-modular code using modular funcionality/macros.

Changes seen here cover the following categories:

  -just replacement of modular macros with their non-modular
   equivalents that CPP would have inserted anyway

  -the removal of including module.h ; replaced with init.h
   as required based on whether the file already had it.

  -the removal of any ".remove" functions that were hooked into
   the driver struct.   This ".remove" function would of
   course not be called from the __exit function since that was
   never run.  However in theory, someone could have triggered it
   via sysfs unbind, even though there isn't a sensible use case
   for doing so.  So to cover that possibility, we've also disabled
   sysfs unbind in the driver.

Recently several of these drivers got removal of the ".remove" fcns
via other changes, so only one remains for which that happens here.

There are no initcall level changes here; everything was at the level
of device_initcall and remains so, by using the builtin equivalents.

Build tested for several different key arch on a recent linux-next
tree to ensure no silly typos crept in.

If there is a desire for any of these to be modular, we can definitely
consider that, but by default the changes here keep the code consistent
with existing behaviour and do not expand functionality into the modular
realm that I can't run time test.

Paul.

---

Cc: Antoine Tenart <antoine.tenart@...e-electrons.com>
Cc: Joachim Eastwood <manabian@...il.com>
Cc: Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc: Maxime Ripard <maxime.ripard@...e-electrons.com>
Cc: Michal Simek <michal.simek@...inx.com>
Cc: Moritz Fischer <moritz.fischer@...us.com>
Cc: Philipp Zabel <p.zabel@...gutronix.de>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
Cc: "Sören Brinkmann" <soren.brinkmann@...inx.com>
Cc: Steffen Trumtrar <s.trumtrar@...gutronix.de>


Paul Gortmaker (5):
  reset: berlin: make it explicitly non-modular
  reset: socfpga: make it explicitly non-modular
  reset: sunxi: make it explicitly non-modular
  reset: zynq: make it explicitly non-modular
  reset: lpc18xx: make it explicitly non-modular

 drivers/reset/reset-berlin.c  | 12 ++++--------
 drivers/reset/reset-lpc18xx.c | 32 +++++---------------------------
 drivers/reset/reset-socfpga.c | 10 ++++------
 drivers/reset/reset-sunxi.c   |  9 ++-------
 drivers/reset/reset-zynq.c    | 10 ++++------
 5 files changed, 19 insertions(+), 54 deletions(-)

-- 
2.8.4

Powered by blists - more mailing lists