linux-kernel - Re: [PATCH] s390/oprofile: Remove deprecated create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bc80939c-0523-60e9-5244-8b7c7b5e26fd@redhat.com>
Date:	Mon, 13 Jun 2016 16:44:19 -0400
From:	William Cohen <wcohen@...hat.com>
To:	Robert Richter <rric@...nel.org>,
	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	Bhaktipriya Shridhar <bhaktipriya96@...il.com>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Tejun Heo <tj@...nel.org>, oprofile-list@...ts.sf.net,
	linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
	Hendrik Brueckner <brueckner@...ux.vnet.ibm.com>,
	Andreas Krebbel <krebbel@...ux.vnet.ibm.com>,
	Andreas Arnez <arnez@...ux.vnet.ibm.com>
Subject: Re: [PATCH] s390/oprofile: Remove deprecated create_workqueue

On 06/13/2016 12:29 PM, Robert Richter wrote:
> Heiko,
> 
> On 09.06.16 11:00:56, Heiko Carstens wrote:
>> However I'm wondering if we shouldn't simply remove at least the s390
>> specific hwswampler code from the oprofile module. This would still leave
>> the common code timer based sampling mode for oprofile working on s390.
>>
>> It looks like the oprofile user space utility nowadays (since 2012) uses
>> the kernel perf interface instead of the oprofile interface anyway, if
>> present. So the oprofile module itself doesn't seem to have too many users
>> left.
>>
>> Any opinions?
> 
> yes, the kernel driver is not necessary for oprofile userland for a
> while now. There is no ongoing development any longer, most patches
> are due to changes in the kernel apis.
> 
> So if there is code that needs a larger rework due to other kernel
> changes and there is no user anymore, I am fine with removing the code
> instead of reworking it. I still would just keep existing code as long
> as we can keep it unchanged (some like the lightwight of oprofile,
> esp. in the embedded space). If there is a user of the code, a
> Tested-by would be good for new code changes.
> 
> If there are users of the hwswampler, speak up now. Else, let's just
> remove it.
> 
> -Robert
> 

Hi,

As Robert mentioned the user-space oprofile code that would have used the oprofile device driver was removed around August 2014 in preparation for oprofile-1.0. The operf command which uses the kernel perf infrastructure and does not need for the oprofile kernel driver has been in oprofile since August of 2012.  For some architectures it would make sense to simplify things by eliminate the oprofile kernel driver.

-Will Cohen